[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 31 06:52:52 PST 2020


jankratochvil marked 2 inline comments as done.
jankratochvil added a comment.

In D73279#1851201 <https://reviews.llvm.org/D73279#1851201>, @labath wrote:

> That might explain the warnings I have seen when building with msvc the other day. It might good to add those too.


Added.



================
Comment at: lldb/unittests/TestingSupport/CMakeLists.txt:4
   MockTildeExpressionResolver.cpp
+  Symbol/YAMLModuleTester.cpp
   TestUtilities.cpp
----------------
labath wrote:
> The idea was then that this would be a separate library (`lldbSymbolHelpers`) with its own CMakeLists.txt and everything.
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73279/new/

https://reviews.llvm.org/D73279





More information about the lldb-commits mailing list