[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D73279#1851068 <https://reviews.llvm.org/D73279#1851068>, @jankratochvil wrote:

> But then maybe it also needs:
>
>   # Our current version of gtest does not properly recognize C++11 support
>   # with MSVC, so it falls back to tr1 / experimental classes.  Since LLVM
>   # itself requires C++11, we can safely force it on unconditionally so that
>   # we don't have to fight with the buggy gtest check.
>   add_definitions(-DGTEST_LANG_CXX11=1)
>   add_definitions(-DGTEST_HAS_TR1_TUPLE=0)
>   
>
> as being used in such cases in cmakefiles in llvm/ but on Linux I do not see if it is really needed here or not.


That might explain the warnings I have seen when building with msvc the other day. It might good to add those too.



================
Comment at: lldb/unittests/TestingSupport/CMakeLists.txt:4
   MockTildeExpressionResolver.cpp
+  Symbol/YAMLModuleTester.cpp
   TestUtilities.cpp
----------------
The idea was then that this would be a separate library (`lldbSymbolHelpers`) with its own CMakeLists.txt and everything.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73279/new/

https://reviews.llvm.org/D73279