[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil updated this revision to Diff 241630.
jankratochvil added a comment.

It needed to add the line:

  include_directories(${LLVM_MAIN_SRC_DIR}/utils/unittest/googlemock/include)

But then maybe it also needs:

  # Our current version of gtest does not properly recognize C++11 support
  # with MSVC, so it falls back to tr1 / experimental classes.  Since LLVM
  # itself requires C++11, we can safely force it on unconditionally so that
  # we don't have to fight with the buggy gtest check.
  add_definitions(-DGTEST_LANG_CXX11=1)
  add_definitions(-DGTEST_HAS_TR1_TUPLE=0)

as being used in such cases in cmakefiles in llvm/ but on Linux I do not see if it is really needed here or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73279/new/

https://reviews.llvm.org/D73279

Files:
  lldb/unittests/Expression/DWARFExpressionTest.cpp
  lldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp
  lldb/unittests/TestingSupport/CMakeLists.txt
  lldb/unittests/TestingSupport/Symbol/YAMLModuleTester.cpp
  lldb/unittests/TestingSupport/Symbol/YAMLModuleTester.h
  lldb/unittests/TestingSupport/module.modulemap

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73279.241630.patch
Type: text/x-patch
Size: 19362 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200131/d6df4d32/attachment-0001.bin>