[Lldb-commits] [PATCH] D72662: dotest.py: Add option to pass extra lldb settings to dotest

[Adrian Prantl via Phabricator via lldb-commits]

aprantl marked an inline comment as done.
aprantl added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/configuration.py:52
+# Any overridden settings.
+settings = []
+
----------------
labath wrote:
> JDevlieghere wrote:
> > To initialize settings to a empty dictionary this should be `{}` or `dict()`.
> True, though that depends on what you really want out of this. I can see how executing the commands in the order that the user set them could be more predictable....
This is intentionally *not* a dictionary :-)

You're supposed to be able to write

`--setting foo=bar --setting foo=baz`

and have both of them applied, in that order.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72662/new/

https://reviews.llvm.org/D72662