[Lldb-commits] [PATCH] D72662: dotest.py: Add option to pass extra lldb settings to dotest

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:787
+def disabledynamics():
+    setSetting('target.prefer-dynamic-value', 'no-dynamic-values')
 
----------------
jingham wrote:
> labath wrote:
> > Maybe you could even put this as the default value for the `settings` variable?
> Not sure what you meant by this, but I don't think "no dynamic values" is the right setting for prefer-dynamic-value for ordinary users of lldb.  For ObjC it is definitely the wrong value (too many things get passed as "id" which is not useful).    But also, every time we break dynamic value determination for C++ we get lots of complaints, so I think this is a feature people really rely on.
I just meant putting `settings = [("target.prefer-dynamic-value", "no-dynamic-values")]` above in configuration.py. That way the setting would be applied automatically, without needing to manually call disabledynamics().


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72662/new/

https://reviews.llvm.org/D72662