[Lldb-commits] [PATCH] D72595: Fix lookup of symbols at the same address with no size vs. size

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

> Apparently ARM32 relies on that section symbol to have proper size. I do not see how Symtab::InitAddressIndexes could handle STT_SECTION in a special way as that is ELF-type specific Symbol characteristics:

Right, so I think that the thing we need to fix is the ObjectFileELF::GetAddressClass implementation. There's no requirement that this function needs to be implemented on top of the Symtab class. In fact, this isn't really true even now, as the function falls back on the hand-maintained map in `m_address_class_map` if the base implementation fails. Maybe we ought to move this logic up front, so that it takes precedence over the base implementation? I'm not sure about that, as I am not that familiar with how the arm/thumb determination is supposed to work, but @omjavaid might be able to help here: How are the arm/thumb mapping symbols supposed to work exactly? What's the "official" algorithm for checking whether a piece of the .text section is arm or thumb?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72595/new/

https://reviews.llvm.org/D72595