[Lldb-commits] [PATCH] D72593: [lldb][NFC] Rewrite python_api/rdar-12481949 test

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 13 02:59:48 PST 2020


teemperor created this revision.
teemperor added reviewers: labath, aprantl.
Herald added subscribers: lldb-commits, JDevlieghere.
Herald added a project: LLDB.

This renames the test `rdar-12481949` to `get-value-32bit-int` as it just tests that we return the
correct result get calling GetValueAsSigned/GetValueAsUnsigned on 32-bit integers.

It also deletes all the strange things going on in this test including resetting the data formatters (which are to my
knowledge not used to calculate scalar values) and testing Python's long integers (let's just assume that our Python
distribution works correctly). Also modernises the setup code.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D72593

Files:
  lldb/packages/Python/lldbsuite/test/python_api/get-value-32bit-int/Makefile
  lldb/packages/Python/lldbsuite/test/python_api/get-value-32bit-int/TestGetValue32BitInt.py
  lldb/packages/Python/lldbsuite/test/python_api/get-value-32bit-int/main.cpp
  lldb/packages/Python/lldbsuite/test/python_api/rdar-12481949/Makefile
  lldb/packages/Python/lldbsuite/test/python_api/rdar-12481949/Test-rdar-12481949.py
  lldb/packages/Python/lldbsuite/test/python_api/rdar-12481949/main.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72593.237606.patch
Type: text/x-patch
Size: 4966 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200113/8e7b419f/attachment-0001.bin>


More information about the lldb-commits mailing list