[Lldb-commits] [PATCH] D72460: RangeDataVector: Support custom sorting for D63540

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 9 08:49:38 PST 2020


jankratochvil marked an inline comment as done.
jankratochvil added inline comments.


================
Comment at: lldb/include/lldb/Utility/RangeMap.h:602
   RangeData(B base, S size, DataType d) : Range<B, S>(base, size), data(d) {}
-
-  bool operator<(const RangeData &rhs) const {
-    if (this->base == rhs.base) {
-      if (this->size == rhs.size)
-        return this->data < rhs.data;
-      else
-        return this->size < rhs.size;
-    }
-    return this->base < rhs.base;
-  }
-
-  bool operator==(const RangeData &rhs) const {
-    return this->GetRangeBase() == rhs.GetRangeBase() &&
-           this->GetByteSize() == rhs.GetByteSize() && this->data == rhs.data;
-  }
-
-  bool operator!=(const RangeData &rhs) const {
-    return this->GetRangeBase() != rhs.GetRangeBase() ||
-           this->GetByteSize() != rhs.GetByteSize() || this->data != rhs.data;
-  }
 };
 
----------------
These functions were used just by `RangeDataVector` (=after I removed them LLDB still builds fine) which no longer uses them so I removed them.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72460/new/

https://reviews.llvm.org/D72460





More information about the lldb-commits mailing list