[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D71372#1810687 <https://reviews.llvm.org/D71372#1810687>, @ted wrote:

> I've got another failure case for this. If the remote gdbserver doesn't implement qMemoryRegionInfo or qXfer:memory-map:read, thread step-out will fail.
>  ....


That's a good point Ted. I think we should give targets which don't support fetching permissions the benefit of the doubt, and treat all memory as potentially executable. Would removing the `return` statement from the `if(!GetLoadAddressPermissions)` branch solve your problem? If so, can you whip up a patch for that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71372/new/

https://reviews.llvm.org/D71372