[Lldb-commits] [PATCH] D72161: [lldb][NFC] Use static_cast instead of reinterpret_cast where possible

[Raphael Isemann via Phabricator via lldb-commits]

teemperor marked an inline comment as done.
teemperor added inline comments.


================
Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:1745
+                     "0x%8.8llx, length = %llu) => %p",
+                     (uint64_t)addr, (uint64_t)length, static_cast<void *>(bp));
     return bp;
----------------
shafik wrote:
> `static_cast<uint64_t>(addr)` and `static_cast<uint64_t>(length)`
Uhm, I agree with removing those C casts, but I don't want to start removing a few random C casts in a patch that is about removing reinterpret_cast (and you anyway already opened a review for removing C casts). I'll can make a separate patch for all the C casts (or we could fix those APIs to not be unsafe variadic functions which would remove the need to cast everything).


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72161/new/

https://reviews.llvm.org/D72161