[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

Mark Mossberg via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 13 09:10:43 PST 2019


mossberg marked an inline comment as done.
mossberg added inline comments.


================
Comment at: lldb/source/Target/ThreadPlanStepOut.cpp:136-137
+                                  m_return_addr);
+      LLDB_LOGF(log, "ThreadPlanStepOut(%p): %s", static_cast<void *>(this),
+                m_constructor_errors.GetData());
+      return;
----------------
labath wrote:
> I'd probably remove the log statements now that we have the real error output.
I included both based on @jingham's feedback here: https://reviews.llvm.org/D71372#1782270


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71372/new/

https://reviews.llvm.org/D71372





More information about the lldb-commits mailing list