[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 13 02:56:39 PST 2019

labath added a comment.

The test looks good. I think it should run fine on linux, and there's a decent chance it might work on windows too. It's fine to let check it in this way, and we can add some skips later if bots start complaining.

As for the location, /maybe/ ExecControl would be a better place for it but it's a bit hard to say because it has only two tests inside. I'd probably but it there, but leaving it in Unwind isn't the end of the world either. We can do the move later once the test structure crystallizes better. I wouldn't worry about duplicating call-asm.c though, as it's super-simple...

Comment at: lldb/source/Target/ThreadPlanStepOut.cpp:136-137
+                                  m_return_addr);
+      LLDB_LOGF(log, "ThreadPlanStepOut(%p): %s", static_cast<void *>(this),
+                m_constructor_errors.GetData());
+      return;
I'd probably remove the log statements now that we have the real error output.

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list