[Lldb-commits] [PATCH] D71440: Extending step-over range past calls was causing deadlocks, fix that.
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Dec 13 02:35:14 PST 2019
labath added a comment.
This looks like a tricky bug. Thanks for tracking it down.
I have two questions though: :D
- could you use c++11 locking primitives in the test? pthreads do not work on windows
- what exactly will be the effect of this? Will we start all threads immediately, or will we do the usual dance of trying to run one thread for a short period of time, and then resume all of them if that times out? If it's the latter, I'm wondering if we really need this call detection logic -- we could theoretically just use the "run all" method all the time (except if explicitly disabled), with the knowledge that all reasonable call-less sequences will finish before the "run single thread" timeout expires. And it would automatically also handle weird call-less sequences with spinlocks or what not...
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits