[Lldb-commits] [lldb] 5536c62 - [lldb] Remove xpasses after pr44037 fix committed

Muhammad Omair Javaid via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 12 23:34:06 PST 2019


Author: Muhammad Omair Javaid
Date: 2019-12-13T12:30:58+05:00
New Revision: 5536c62f3c35015802dd59150d422c4ab79db581

URL: https://github.com/llvm/llvm-project/commit/5536c62f3c35015802dd59150d422c4ab79db581
DIFF: https://github.com/llvm/llvm-project/commit/5536c62f3c35015802dd59150d422c4ab79db581.diff

LOG: [lldb] Remove xpasses after pr44037 fix committed

This patch removes xpass decorator from tests which were failing due to
pr44037.

pr44037 was fixed by rev 6ce1a897b6a82e18059fd3b75b8d52ff12c2a605

Added: 
    

Modified: 
    lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py
    lldb/packages/Python/lldbsuite/test/lang/c/inlines/TestRedefinitionsInInlines.py
    lldb/packages/Python/lldbsuite/test/lang/cpp/member-and-local-vars-with-same-name/TestMembersAndLocalsWithSameName.py
    lldb/packages/Python/lldbsuite/test/python_api/frame/inlines/TestInlinedFrame.py

Removed: 
    


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py b/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py
index 1dc12e94eaf6..2a5c111d5826 100644
--- a/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py
+++ b/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py
@@ -16,26 +16,16 @@ class BreakpointLocationsTestCase(TestBase):
     mydir = TestBase.compute_mydir(__file__)
 
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528")
-    @expectedFailureAll(archs=["aarch64"], oslist=["linux"],
-                        debug_info=["dwo"],
-                        bugnumber="llvm.org/pr44037")
     def test_enable(self):
         """Test breakpoint enable/disable for a breakpoint ID with multiple locations."""
         self.build()
         self.breakpoint_locations_test()
 
-    @expectedFailureAll(archs=["aarch64"], oslist=["linux"],
-                        debug_info=["dwo"],
-                        bugnumber="llvm.org/pr44037")
     def test_shadowed_cond_options(self):
         """Test that options set on the breakpoint and location behave correctly."""
         self.build()
         self.shadowed_bkpt_cond_test()
 
-
-    @expectedFailureAll(archs=["aarch64"], oslist=["linux"],
-                        debug_info=["dwo"],
-                        bugnumber="llvm.org/pr44037")
     def test_shadowed_command_options(self):
         """Test that options set on the breakpoint and location behave correctly."""
         self.build()

diff  --git a/lldb/packages/Python/lldbsuite/test/lang/c/inlines/TestRedefinitionsInInlines.py b/lldb/packages/Python/lldbsuite/test/lang/c/inlines/TestRedefinitionsInInlines.py
index 1e829901cf11..311c5ec8e120 100644
--- a/lldb/packages/Python/lldbsuite/test/lang/c/inlines/TestRedefinitionsInInlines.py
+++ b/lldb/packages/Python/lldbsuite/test/lang/c/inlines/TestRedefinitionsInInlines.py
@@ -6,8 +6,4 @@
                           [decorators.expectedFailureAll(compiler="clang",
                                                          compiler_version=["<",
                                                                            "3.5"],
-                                                         bugnumber="llvm.org/pr27845"),
-                           decorators.expectedFailureAll(archs="aarch64",
-                                                         oslist="linux",
-                                                         debug_info="dwo",
-                                                         bugnumber="llvm.org/pr44037")])
+                                                         bugnumber="llvm.org/pr27845")])

diff  --git a/lldb/packages/Python/lldbsuite/test/lang/cpp/member-and-local-vars-with-same-name/TestMembersAndLocalsWithSameName.py b/lldb/packages/Python/lldbsuite/test/lang/cpp/member-and-local-vars-with-same-name/TestMembersAndLocalsWithSameName.py
index ac964a35fecb..a0dcbf002664 100644
--- a/lldb/packages/Python/lldbsuite/test/lang/cpp/member-and-local-vars-with-same-name/TestMembersAndLocalsWithSameName.py
+++ b/lldb/packages/Python/lldbsuite/test/lang/cpp/member-and-local-vars-with-same-name/TestMembersAndLocalsWithSameName.py
@@ -8,9 +8,6 @@ class TestMembersAndLocalsWithSameName(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
 
-    @expectedFailureAll(archs=["aarch64"], oslist=["linux"],
-                        debug_info=["dwo"],
-                        bugnumber="llvm.org/pr44037")
     def test_when_stopped_in_method(self):
         self._load_exe()
 
@@ -113,9 +110,6 @@ def test_when_stopped_in_method(self):
         self.assertTrue(val.IsValid())
         self.assertEqual(val.GetValueAsUnsigned(), 778899)
 
-    @expectedFailureAll(archs=["aarch64"], oslist=["linux"],
-                        debug_info=["dwo"],
-                        bugnumber="llvm.org/pr44037")
     def test_when_stopped_in_function(self):
         self._load_exe()
 

diff  --git a/lldb/packages/Python/lldbsuite/test/python_api/frame/inlines/TestInlinedFrame.py b/lldb/packages/Python/lldbsuite/test/python_api/frame/inlines/TestInlinedFrame.py
index 1fdd477e22e1..da4e9cb06e7b 100644
--- a/lldb/packages/Python/lldbsuite/test/python_api/frame/inlines/TestInlinedFrame.py
+++ b/lldb/packages/Python/lldbsuite/test/python_api/frame/inlines/TestInlinedFrame.py
@@ -26,9 +26,6 @@ def setUp(self):
             self.source, '// This should correspond to the second break stop.')
 
     @add_test_categories(['pyapi'])
-    @expectedFailureAll(archs=["aarch64"], oslist=["linux"],
-                        debug_info=["dwo"],
-                        bugnumber="llvm.org/pr44037")
     def test_stop_at_outer_inline(self):
         """Exercise SBFrame.IsInlined() and SBFrame.GetFunctionName()."""
         self.build()


        


More information about the lldb-commits mailing list