[Lldb-commits] [PATCH] D71299: [FormatManager] Add a unittest for GetCandidateLanguages()

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Dec 11 02:35:46 PST 2019


teemperor added inline comments.


================
Comment at: lldb/unittests/DataFormatter/FormatManagerTests.cpp:9-24
+#include "TestingSupport/TestUtilities.h"
+
+#include "lldb/Core/Mangled.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleSpec.h"
+#include "lldb/DataFormatters/FormatManager.h"
+#include "lldb/Host/FileSystem.h"
----------------
labath wrote:
> This is a pretty long list of includes for such a simple test. Are you sure all of them are needed?
Cleaned up includes in 987e7323fb53f968d5878483610fcf2319cdde86


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71299/new/

https://reviews.llvm.org/D71299





More information about the lldb-commits mailing list