[Lldb-commits] [PATCH] D71299: [FormatManager] Add a unittest for GetCandidateLanguages()
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Dec 11 02:02:17 PST 2019
labath added inline comments.
================
Comment at: lldb/unittests/DataFormatter/FormatManagerTests.cpp:9-24
+#include "TestingSupport/TestUtilities.h"
+
+#include "lldb/Core/Mangled.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleSpec.h"
+#include "lldb/DataFormatters/FormatManager.h"
+#include "lldb/Host/FileSystem.h"
----------------
This is a pretty long list of includes for such a simple test. Are you sure all of them are needed?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71299/new/
https://reviews.llvm.org/D71299
More information about the lldb-commits
mailing list