[Lldb-commits] [lldb] b0937be - Skip TestGuiBasic.py on ios etc device testing.

[Jason Molenda via lldb-commits]

That was my first inclination -- I don't see how it can work correctly on a remote setup, just like TestMultilineCompletion.py which I added the same skip to -- but I know people are doing remote linux testing for android and this doesn't seem to have been a problem for them?  I went the conservative approach of skipping it for iOS testing, but I think skipIfRemote is the correct decorator.

> On Dec 10, 2019, at 3:47 PM, Frédéric Riss <friss at apple.com> wrote:
> 
> I think it would be better to stick the equivalent of skipIfRemote in the Expect base class.
> 
>> On Dec 10, 2019, at 3:15 PM, Jason Molenda via lldb-commits <lldb-commits at lists.llvm.org> wrote:
>> 
>> 
>> Author: Jason Molenda
>> Date: 2019-12-10T15:15:25-08:00
>> New Revision: b0937be06e44c0cdc1c1aac16b76746150e70154
>> 
>> URL: https://github.com/llvm/llvm-project/commit/b0937be06e44c0cdc1c1aac16b76746150e70154
>> DIFF: https://github.com/llvm/llvm-project/commit/b0937be06e44c0cdc1c1aac16b76746150e70154.diff
>> 
>> LOG: Skip TestGuiBasic.py on ios etc device testing.
>> 
>> Added: 
>> 
>> 
>> Modified: 
>>   lldb/packages/Python/lldbsuite/test/commands/gui/basic/TestGuiBasic.py
>> 
>> Removed: 
>> 
>> 
>> 
>> ################################################################################
>> diff  --git a/lldb/packages/Python/lldbsuite/test/commands/gui/basic/TestGuiBasic.py b/lldb/packages/Python/lldbsuite/test/commands/gui/basic/TestGuiBasic.py
>> index d501b266cc12..0ee0982a5b42 100644
>> --- a/lldb/packages/Python/lldbsuite/test/commands/gui/basic/TestGuiBasic.py
>> +++ b/lldb/packages/Python/lldbsuite/test/commands/gui/basic/TestGuiBasic.py
>> @@ -15,6 +15,7 @@ class BasicGuiCommandTest(PExpectTest):
>>    # under ASAN on a loaded machine..
>>    @skipIfAsan
>>    @skipIfCursesSupportMissing
>> +    @skipIfDarwinEmbedded # "run" command will not work correctly for remote debug
>>    def test_gui(self):
>>        self.build()
>> 
>> 
>> 
>> 
>> _______________________________________________
>> lldb-commits mailing list
>> lldb-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>