[Lldb-commits] [lldb] b0937be - Skip TestGuiBasic.py on ios etc device testing.

Frédéric Riss via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 10 15:47:15 PST 2019


I think it would be better to stick the equivalent of skipIfRemote in the Expect base class.

> On Dec 10, 2019, at 3:15 PM, Jason Molenda via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> 
> 
> Author: Jason Molenda
> Date: 2019-12-10T15:15:25-08:00
> New Revision: b0937be06e44c0cdc1c1aac16b76746150e70154
> 
> URL: https://github.com/llvm/llvm-project/commit/b0937be06e44c0cdc1c1aac16b76746150e70154
> DIFF: https://github.com/llvm/llvm-project/commit/b0937be06e44c0cdc1c1aac16b76746150e70154.diff
> 
> LOG: Skip TestGuiBasic.py on ios etc device testing.
> 
> Added: 
> 
> 
> Modified: 
>    lldb/packages/Python/lldbsuite/test/commands/gui/basic/TestGuiBasic.py
> 
> Removed: 
> 
> 
> 
> ################################################################################
> diff  --git a/lldb/packages/Python/lldbsuite/test/commands/gui/basic/TestGuiBasic.py b/lldb/packages/Python/lldbsuite/test/commands/gui/basic/TestGuiBasic.py
> index d501b266cc12..0ee0982a5b42 100644
> --- a/lldb/packages/Python/lldbsuite/test/commands/gui/basic/TestGuiBasic.py
> +++ b/lldb/packages/Python/lldbsuite/test/commands/gui/basic/TestGuiBasic.py
> @@ -15,6 +15,7 @@ class BasicGuiCommandTest(PExpectTest):
>     # under ASAN on a loaded machine..
>     @skipIfAsan
>     @skipIfCursesSupportMissing
> +    @skipIfDarwinEmbedded # "run" command will not work correctly for remote debug
>     def test_gui(self):
>         self.build()
> 
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits



More information about the lldb-commits mailing list