[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 9 00:23:24 PST 2019

labath added a comment.

While I'm not opposed to moving "lldbsuite" to some place closer to the tests, one thing I'd like to get out of this is to have the actual tests stand out more prominently. For that reason, I wouldn't want to just take the "lldbsuite" folder and "drop" it into `test/API`. In fact, ideally I'd like to get rid of the redundant nested `test` subfolder, and put the tests directly into `test/API`.

However, like I said in the other review, if lua is going to become a thing, we should evaluate how will this layout work with additional scripting languages: I see several options here:

- make a subfolder for each language (`test/API/{Python,Lua}`)
- ditch the "API" part and put these at the top level (`test/{Python,Lua}`)
- keep Python in "API", but put lua in Lua (`test/{API,Lua}`) -- besides backward compat, this would kind of signal that "python" is our preferred vessel for writing tests
- ???

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list