[Lldb-commits] [PATCH] D71022: [lldb] NFC: less nesting in SearchFilter.cpp

[Raphael Isemann via Phabricator via lldb-commits]

teemperor accepted this revision.
teemperor added a comment.

I have one minor request (see inline comments), but otherwise LGTM, thanks!



================
Comment at: lldb/source/Core/SearchFilter.cpp:777
     lldb::ModuleSP module_sp = target_images.GetModuleAtIndexUnlocked(i);
-    if (no_modules_in_filter ||
+    if (!(no_modules_in_filter ||
         m_module_spec_list.FindFileIndex(0, module_sp->GetFileSpec(), false) !=
----------------
Simplify with de Morgan (or maybe we could get rid of the `no_modules_in_filter` as this just seems to be an "optimization" to avoid the `FindFileIndex` function call, but just getting rid of the `!(...)` is fine).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71022/new/

https://reviews.llvm.org/D71022