[Lldb-commits] [PATCH] D71022: [lldb] NFC: less nesting in SearchFilter.cpp

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Dec 4 09:41:59 PST 2019


JDevlieghere accepted this revision.
JDevlieghere added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Core/SearchFilter.cpp:625
                                                  modules_array);
   FileSpecList modules;
+  if (!success)
----------------
I'd move this down and use 
```
  if (!success)
    return std::make_shared<SearchFilterByModuleList>(target.shared_from_this(),{});

```
to make it clear the list of modules is empty.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71022/new/

https://reviews.llvm.org/D71022





More information about the lldb-commits mailing list