[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 15 09:21:04 PST 2019


teemperor added a comment.

In D70314#1747711 <https://reviews.llvm.org/D70314#1747711>, @labath wrote:

> Semi-random idea: Instead of running the expression through the command line and then unpacking the result, should we just use the appropriate SBFrame api here (EvaluateExpression/GetValueForVariablePath)?


That's one of the APIs we need to test, but we need to test all of them to prevent regressions like D67803 <https://reviews.llvm.org/D67803>. At least `frame var` and `expr` behave very differently (EvaluateExpression should be similar to `expr` but I never looked at that code path). So the idea is to have one command that tests all these APIs and if we can't do that (for example because the expression can't be repeated with the same result), at least make that safer/easier to do.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70314/new/

https://reviews.llvm.org/D70314





More information about the lldb-commits mailing list