[Lldb-commits] [lldb] 3bc7119 - Comment the fact that DWARFDebugInfoEntry isn't copyable.

Adrian Prantl via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 15 09:14:55 PST 2019


Author: Adrian Prantl
Date: 2019-11-15T09:14:48-08:00
New Revision: 3bc71193bd4f29ebb5e5baa11581909972265b4f

URL: https://github.com/llvm/llvm-project/commit/3bc71193bd4f29ebb5e5baa11581909972265b4f
DIFF: https://github.com/llvm/llvm-project/commit/3bc71193bd4f29ebb5e5baa11581909972265b4f.diff

LOG: Comment the fact that DWARFDebugInfoEntry isn't copyable.

Added: 
    

Modified: 
    lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h b/lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h
index 25c885608d85..f3952ae9598b 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h
@@ -23,6 +23,10 @@ class DWARFDeclContext;
 
 #define DIE_SIBLING_IDX_BITSIZE 31
 
+/// DWARFDebugInfoEntry objects assume that they are living in one big
+/// vector and do pointer arithmetic on their this pointers. Don't
+/// pass them by value. Due to the way they are constructed in a
+/// std::vector, we cannot delete the copy constructor.
 class DWARFDebugInfoEntry {
 public:
   typedef std::vector<DWARFDebugInfoEntry> collection;


        


More information about the lldb-commits mailing list