[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: include/lldb/Symbol/CompileUnit.h:172
+  /// \return
+  ///   The FunctionSP containing the first matching entry.
+  lldb::FunctionSP
----------------
Document what does the bool return value do?


================
Comment at: source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp:299
+
+    lldb::FunctionSP fsp = vtable_cu->FindFunction(find_function_matcher);
+
----------------
func_sp?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69913/new/

https://reviews.llvm.org/D69913