[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 6 16:47:32 PST 2019


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Seems fine otherwise, I think.



================
Comment at: include/lldb/Symbol/CompileUnit.h:174
+  lldb::FunctionSP
+  FindFunction(llvm::function_ref<bool(const llvm::StringRef)> matching_lambda);
+
----------------
perhaps calling it `is_match` makes this more obvious?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69913/new/

https://reviews.llvm.org/D69913





More information about the lldb-commits mailing list