[Lldb-commits] [PATCH] D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up

[Adrian McCarthy via Phabricator via lldb-commits]

amccarth added a comment.

In D69503#1726841 <https://reviews.llvm.org/D69503#1726841>, @labath wrote:

> (Ideally, I'd just delete ProcessWindows entirely, and move everything to lldb-server based model -- it's much easier to reason about threads there)


I believe there are people working on moving the Windows bits to the lldb-server model, but I don't think it's far enough along to get rid of ProcessWindows just yet.

The `m_mutex` is supposed to protect `m_session_data`.   `OnExitProcess` says:

  // No need to acquire the lock since m_session_data isn't accessed.

but it actually does access m_session_data.

So I think you've identified the cause of the race condition, but I'm not sure whether this is the best fix.  I need a little time to look at this more closely.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69503/new/

https://reviews.llvm.org/D69503