[Lldb-commits] [PATCH] D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Oct 30 04:13:38 PDT 2019
labath added a comment.
In D69503#1726823 <https://reviews.llvm.org/D69503#1726823>, @mstorsjo wrote:
> What's the correct course of action here? Remove the `m_session_data.reset()` from ProcessWindows::OnExitProcess, concluding that it's up to some other class to clear `m_session_data` in this case?
I'm not really familiar with this code, but removing the reset() call does not sound completely unreasonable to me. I think the only one who may have enough context here is @amccarth, so maybe let's wait if he has to say anything?
(Ideally, I'd just delete ProcessWindows entirely, and move everything to lldb-server based model -- it's much easier to reason about threads there)
CHANGES SINCE LAST ACTION
More information about the lldb-commits