[Lldb-commits] [lldb] f8a92af - [LLDB] Remove incorrect dotest.py invocation

[Adrian McCarthy via lldb-commits]

It looks like this was the only call to getRerunArgs, so why not delete it?

On Mon, Oct 28, 2019 at 1:24 PM Jonas Devlieghere via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

>
> Author: Jonas Devlieghere
> Date: 2019-10-28T13:24:07-07:00
> New Revision: f8a92af893eee7ac7ffda93c24b9e69df506148f
>
> URL:
> https://github.com/llvm/llvm-project/commit/f8a92af893eee7ac7ffda93c24b9e69df506148f
> DIFF:
> https://github.com/llvm/llvm-project/commit/f8a92af893eee7ac7ffda93c24b9e69df506148f.diff
>
> LOG: [LLDB] Remove incorrect dotest.py invocation
>
> The invocation shown by dotest.py to re-run a single test is misleading:
> it ranges from missing arguments (best case scenario) to being totally
> wrong (worst case scenario).
>
> In the past I've tried to get it right, but given the dotest
> architecture this is harder than it looks. Furthermore, we have pretty
> good documentation on the website [1] for most use cases.
>
> This patch removes the rerun invocation.
>
> [1] https://lldb.llvm.org/resources/test.html
>
> Added:
>
>
> Modified:
>     lldb/packages/Python/lldbsuite/test/lldbtest.py
>
> Removed:
>
>
>
>
> ################################################################################
> diff  --git a/lldb/packages/Python/lldbsuite/test/lldbtest.py
> b/lldb/packages/Python/lldbsuite/test/lldbtest.py
> index 34e6aa8f460d..f3165ab32585 100644
> --- a/lldb/packages/Python/lldbsuite/test/lldbtest.py
> +++ b/lldb/packages/Python/lldbsuite/test/lldbtest.py
> @@ -1169,27 +1169,11 @@ def dumpSessionInfo(self):
>                  if test is self:
>                      print(traceback, file=self.session)
>
> -        # put footer (timestamp/rerun instructions) into session
> -        testMethod = getattr(self, self._testMethodName)
> -        if getattr(testMethod, "__benchmarks_test__", False):
> -            benchmarks = True
> -        else:
> -            benchmarks = False
> -
>          import datetime
>          print(
>              "Session info generated @",
>              datetime.datetime.now().ctime(),
>              file=self.session)
> -        print(
> -            "To rerun this test, issue the following command from the
> 'test' directory:\n",
> -            file=self.session)
> -        print(
> -            "./dotest.py %s -v %s %s" %
> -            (self.getRunOptions(),
> -             ('+b' if benchmarks else '-t'),
> -                self.getRerunArgs()),
> -            file=self.session)
>          self.session.close()
>          del self.session
>
>
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191028/c6054008/attachment.html>