<div dir="ltr">It looks like this was the only call to getRerunArgs, so why not delete it?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 28, 2019 at 1:24 PM Jonas Devlieghere via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Jonas Devlieghere<br>
Date: 2019-10-28T13:24:07-07:00<br>
New Revision: f8a92af893eee7ac7ffda93c24b9e69df506148f<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/f8a92af893eee7ac7ffda93c24b9e69df506148f" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/f8a92af893eee7ac7ffda93c24b9e69df506148f</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/f8a92af893eee7ac7ffda93c24b9e69df506148f.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/f8a92af893eee7ac7ffda93c24b9e69df506148f.diff</a><br>
<br>
LOG: [LLDB] Remove incorrect dotest.py invocation<br>
<br>
The invocation shown by dotest.py to re-run a single test is misleading:<br>
it ranges from missing arguments (best case scenario) to being totally<br>
wrong (worst case scenario).<br>
<br>
In the past I've tried to get it right, but given the dotest<br>
architecture this is harder than it looks. Furthermore, we have pretty<br>
good documentation on the website [1] for most use cases.<br>
<br>
This patch removes the rerun invocation.<br>
<br>
[1] <a href="https://lldb.llvm.org/resources/test.html" rel="noreferrer" target="_blank">https://lldb.llvm.org/resources/test.html</a><br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    lldb/packages/Python/lldbsuite/test/lldbtest.py<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/lldb/packages/Python/lldbsuite/test/lldbtest.py b/lldb/packages/Python/lldbsuite/test/lldbtest.py<br>
index 34e6aa8f460d..f3165ab32585 100644<br>
--- a/lldb/packages/Python/lldbsuite/test/lldbtest.py<br>
+++ b/lldb/packages/Python/lldbsuite/test/lldbtest.py<br>
@@ -1169,27 +1169,11 @@ def dumpSessionInfo(self):<br>
                 if test is self:<br>
                     print(traceback, file=self.session)<br>
<br>
-        # put footer (timestamp/rerun instructions) into session<br>
-        testMethod = getattr(self, self._testMethodName)<br>
-        if getattr(testMethod, "__benchmarks_test__", False):<br>
-            benchmarks = True<br>
-        else:<br>
-            benchmarks = False<br>
-<br>
         import datetime<br>
         print(<br>
             "Session info generated @",<br>
             datetime.datetime.now().ctime(),<br>
             file=self.session)<br>
-        print(<br>
-            "To rerun this test, issue the following command from the 'test' directory:\n",<br>
-            file=self.session)<br>
-        print(<br>
-            "./dotest.py %s -v %s %s" %<br>
-            (self.getRunOptions(),<br>
-             ('+b' if benchmarks else '-t'),<br>
-                self.getRerunArgs()),<br>
-            file=self.session)<br>
         self.session.close()<br>
         del self.session<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>