[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 25 16:29:22 PDT 2019


labath added a comment.

Right. I see what you mean.

But... does this have to happen at build time? Since the list of files is already known at configuration time, you should be able to generate the files in the "cmake" step (but still leave the copying for the build step, so that any changes to the files are reflected in rebuilds).

(I'm not insisting on that -- I think that the current patch is already much better than what we had before. If you think that the python script is better than that, feel free to say so.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69019/new/

https://reviews.llvm.org/D69019





More information about the lldb-commits mailing list