[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

[Haibo Huang via Phabricator via lldb-commits]

hhb added a comment.

In D69019#1721867 <https://reviews.llvm.org/D69019#1721867>, @labath wrote:

> I'm sorry, this dropped off my radar. The only question I have here is about the createPythonInit.py script. If we're moving stuff to cmake, I am wondering if we shouldn't move that thing too? It doesn't look like the code is doing anything which would be hard to replicate in cmake. WDYT ?


I didn't find a good way to generate file using cmake at build time... Did I miss something?

The closest way I see is to create a new .cmake script with file(WRITE ...) in it. And invoke cmake to run this new script at build time. But that doesn't seem much better than this simple python script.

In my opinion, python is better than cmake for string processing. As long as we don't reinvent too many cmake functionality in python, it is not a problem to have a small python script...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69019/new/

https://reviews.llvm.org/D69019