[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream
Fangrui Song via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Oct 16 01:24:36 PDT 2019
MaskRay added inline comments.
================
Comment at: llvm/lib/ObjectYAML/MinidumpYAML.cpp:389
+ for (size_t Index = 0; Index < Exception.MaxParameters; ++Index) {
+ SmallString<16> Name = formatv("Parameter {0}", Index);
+ support::ulittle64_t &Field = Exception.ExceptionInformation[Index];
----------------
You may use `("Parameter " + Twine(Index)).str()` to get rid of the "llvm/Support/FormatVariadic.h" dependency.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68657/new/
https://reviews.llvm.org/D68657
More information about the lldb-commits
mailing list