[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

[George Rimar via Phabricator via lldb-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/minidump-exception-missing-parameter.yaml:3
+
+# Test that we report an error for an ExceptionStream where the specified
+# number of parameters is greater than the number of ExceptionInformation
----------------
JosephTremoulet wrote:
> grimar wrote:
> > nit: It is became common to use ## for comments in yaml2obj and actually many other LLVM tools test cases.
> > (here and below)
> Sorry, when you say "here and below", do you just mean lines 3 and 4-5, or do you also mean the CHECK line (line 20)?  Grepping in test/tools it appears to be very uncommon to use ## for CHECK lines, but that's what I'd have otherwise assumed "and below" referred to...
Sorry, I think I misread the line 20, i.e. I read it as a comment. Indeed we do not use ## for CHECK lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68657/new/

https://reviews.llvm.org/D68657