[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

[David CARLIER via Phabricator via lldb-commits]

devnexen added a comment.

In D68723#1703098 <https://reviews.llvm.org/D68723#1703098>, @MaskRay wrote:

> In D68723#1703051 <https://reviews.llvm.org/D68723#1703051>, @devnexen wrote:
>
> > LGTM otherwise.
>
>
> I don't think this change should be reverted. It can just be repaired by adding some `(void)!xxx;`




In D68723#1703098 <https://reviews.llvm.org/D68723#1703098>, @MaskRay wrote:

> In D68723#1703051 <https://reviews.llvm.org/D68723#1703051>, @devnexen wrote:
>
> > LGTM otherwise.
>
>
> I don't think this change should be reverted. It can just be repaired by adding some `(void)!xxx;`


I would prefer this approach indeed but either way I m in that s a real issue at the moment since LLVM runtime check is on in the FreeBSD's system.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68723/new/

https://reviews.llvm.org/D68723