[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 10 01:44:53 PDT 2019


labath added a comment.

I don't think having Expected<T> members is a reasonable thing to do. If we want to keep the notion of validity explicit (which is consistent with the direction lldb is moving in), then I think the members should be Optional<T>. The initialization code can take the Expected<T> result, do something with the error, and then emplace the result into the Optional<T> member in case of success.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68723/new/

https://reviews.llvm.org/D68723





More information about the lldb-commits mailing list