[Lldb-commits] [PATCH] D68456: [lldb] [cmake] Support linking against clang-cpp dylib

[Michał Górny via Phabricator via lldb-commits]

mgorny marked an inline comment as done.
mgorny added inline comments.


================
Comment at: lldb/cmake/modules/AddLLDB.cmake:94-99
+
+    if(CLANG_LINK_CLANG_DYLIB)
+      target_link_libraries(${name} PRIVATE clang-cpp)
+    else()
+      target_link_libraries(${name} PRIVATE ${PARAM_CLANG_LIBS})
+    endif()
----------------
labath wrote:
> I don't know whether this makes any difference, but I am wondering if we should pass these (both clang-cpp and PARAM_CLANG_LIBS) as the LINK_LIBS argument to the llvm_add_library call above. Seems like it would be more consistent with the approach of letting the llvm function manage linking. WDYT?
I presumed it doesn't, so went for the simpler approach ;-). I can change it if you prefer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68456/new/

https://reviews.llvm.org/D68456