[Lldb-commits] [PATCH] D68422: [DWARFASTParserClang] Factor out structure-like type parsing, NFC

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 3 23:58:32 PDT 2019


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks good to me. Thanks for doing this. Personally, I'd just remove the `Log` argument from the function argument list, and let the function re-fetch it if needed. I know we sometimes pass around a `Log*` variable, but most of the time we don't...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68422/new/

https://reviews.llvm.org/D68422





More information about the lldb-commits mailing list