[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays
Alex Cameron via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Oct 2 17:13:50 PDT 2019
tetsuo-cpp added a comment.
Thank you for the suggestions!
I'm assuming that since only the `debugserver` portion of this change is left, I should write a test specifically for that. I had a quick look and it wasn't obvious how to do that but I will spend some more time on it this weekend.
Regarding the idea of a serialization test, I've only ever triggered the bug by manually adding an empty array to some breakpoint JSON. I'm not sure how the reporter stumbled across the issue "naturally". Is it ok to have a serialization test where the test itself edits the JSON after it has been written? Or would it be better if I find some scenario where LLDB writes JSON with an empty array and trigger the bug by reading it back in?
CHANGES SINCE LAST ACTION
More information about the lldb-commits