[Lldb-commits] [PATCH] D68291: [process list] make the TRIPLE column wider

[walter erquinigo via Phabricator via lldb-commits]

wallace created this revision.
wallace added reviewers: clayborg, labath, xiaobai, aadsm.
Herald added subscribers: lldb-commits, kristof.beyls.
Herald added a project: LLDB.

Now that `process list` works better on the android platform, the arch aarch64-unknown-linux-android appears quite often.
The existing printed width of the TRIPLE column is not long enough, which doesn't look okay.
E.g.

  1561   1016                    aarch64-unknown-linux-android ip6tables-restore
  1999   1                       aarch64-unknown-linux-android tlc_server
  2332   982                                              com.android.systemui
  2378   983                                              webview_zygote

Now, after adding 6 spaces, it looks better

  PID    PARENT USER       TRIPLE                         NAME
  ====== ====== ========== ============================== ============================
  ...
  1561   1016              aarch64-unknown-linux-android  ip6tables-restore
  1999   1                 aarch64-unknown-linux-android  tlc_server
  2332   982                                              com.android.systemui
  2378   983                                              webview_zygote
  2448   982                                              com.sec.location.nsflp2


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68291

Files:
  lldb/source/Utility/ProcessInfo.cpp


Index: lldb/source/Utility/ProcessInfo.cpp
===================================================================
--- lldb/source/Utility/ProcessInfo.cpp
+++ lldb/source/Utility/ProcessInfo.cpp
@@ -169,13 +169,15 @@
 
   if (verbose) {
     s.Printf("PID    PARENT USER       GROUP      EFF USER   EFF GROUP  TRIPLE "
-             "                  %s\n",
+             "                              %s\n",
              label);
-    s.PutCString("====== ====== ========== ========== ========== ========== "
-                 "======================== ============================\n");
+    s.PutCString(
+        "====== ====== ========== ========== ========== ========== "
+        "============================== ============================\n");
   } else {
-    s.Printf("PID    PARENT USER       TRIPLE                   %s\n", label);
-    s.PutCString("====== ====== ========== ======================== "
+    s.Printf("PID    PARENT USER       TRIPLE                         %s\n",
+             label);
+    s.PutCString("====== ====== ========== ============================== "
                  "============================\n");
   }
 }
@@ -216,12 +218,12 @@
             &ProcessInstanceInfo::GetEffectiveGroupID,
             &UserIDResolver::GetGroupName);
 
-      s.Printf("%-24s ", arch_strm.GetData());
+      s.Printf("%-30s ", arch_strm.GetData());
     } else {
       print(&ProcessInstanceInfo::EffectiveUserIDIsValid,
             &ProcessInstanceInfo::GetEffectiveUserID,
             &UserIDResolver::GetUserName);
-      s.Printf("%-24s ", arch_strm.GetData());
+      s.Printf("%-30s ", arch_strm.GetData());
     }
 
     if (verbose || show_args) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68291.222676.patch
Type: text/x-patch
Size: 1682 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191001/c8699e6b/attachment-0001.bin>