[Lldb-commits] [PATCH] D68278: Fix evaluation of nested classes with parent from other CU
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Oct 1 10:02:54 PDT 2019
labath added reviewers: clayborg, JDevlieghere.
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Herald added a reviewer: shafik.
Just a bit more context (we were discussing this with Jaroslav offline): without this line, the `GetClangDeclContextForDie` method will fail to locate the clang decl context for the `OuterA::Inner` class because the class `OuterA` has been parsed and linked to the DIE in other.cpp's debug info when the first expression was evaluated. I've looked through the code and this fix makes sense to me, but I am not super-familiar with this, so I'd appreciate if someone could have another look.
Comment at: packages/Python/lldbsuite/test/lang/cpp/nested-class-other-compilation-unit/Makefile:1-2
+LEVEL = ../../../make
+CXX_SOURCES := main.cpp other.cpp
This level stuff is no longer necessary.
CHANGES SINCE LAST ACTION
More information about the lldb-commits