[Lldb-commits] [PATCH] D68248: [JSON] Use LLVM's library for encoding JSON

Tue Oct 1 09:17:36 PDT 2019

JDevlieghere added a comment.

In D68248#1688975 <https://reviews.llvm.org/D68248#1688975>, @vsk wrote:

> Sweet! Does this 'automatically' fix the 'llvm-argdumper has issues escaping JSON-ified input' issue we discussed in person?

No, that uses the JSON class that Pavel mentioned. My hope is to remove that altogether in favor of the LLVM counterpart.

In D68248#1689855 <https://reviews.llvm.org/D68248#1689855>, @aprantl wrote:

> Cool. I mean both are supposed to be JSON, but are we expecting any fallout from a debugserver using the old library vs and lldb using the new one? I suppose not..

I ran the test suite with the just-built debugserver and didn't notice any regressions. If this does come up we should fix the debugserver implementation.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68248/new/

https://reviews.llvm.org/D68248