[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Sep 30 10:32:11 PDT 2019
jingham added a comment.
It would be good as Pavel and Davide suggest to write a test directly for the JSON parser. Doing so in the C++ Unit test seems the most convenient, but that's up to you. But it would also be good to add a test for the particular "breakpoint write" -> "breakpoint read" scenario that uncovered this bug. There are already some tests for that in the functionalities/breakpoints/serialize test case, so it should be easy to add one there.
CHANGES SINCE LAST ACTION
More information about the lldb-commits