[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Unify and correct Python module installation paths

Haibo Huang via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 23 14:55:32 PDT 2019


hhb added inline comments.


================
Comment at: lldb/scripts/Python/prepare_binding_Python.py:284
+        module_path = options.python_relative_path
+        if module_path is None:
+            from distutils.sysconfig import get_python_lib
----------------
hhb wrote:
> Just bail out in this situation? So that the error can be more obvious. E.g. someone changed cmake file but didn't know to update here.
finishSwigPythonLLDB.py also need to be updated similar to what you did here. Specially get_framework_python_dir() and make_symlink().


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67890/new/

https://reviews.llvm.org/D67890





More information about the lldb-commits mailing list