[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Unify and correct Python module installation paths

[Haibo Huang via Phabricator via lldb-commits]

hhb added inline comments.


================
Comment at: lldb/scripts/Python/prepare_binding_Python.py:284
+        module_path = options.python_relative_path
+        if module_path is None:
+            from distutils.sysconfig import get_python_lib
----------------
Just bail out in this situation? So that the error can be more obvious. E.g. someone changed cmake file but didn't know to update here.


================
Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:326
   llvm::sys::path::remove_filename(path, style);
   llvm::sys::path::append(path, style, "lib", "site-packages");
 
----------------
Also update the path for windows using LLDB_PYTHON_RELATIVE_LIBDIR?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67890/new/

https://reviews.llvm.org/D67890