[Lldb-commits] [PATCH] D67792: bugfix: llvm_private::File::GetStream() can fail if m_options == 0

[Lawrence D'Anna via Phabricator via lldb-commits]

lawrence_danna added a comment.

In D67792#1676556 <https://reviews.llvm.org/D67792#1676556>, @labath wrote:

> It doesn't look like this will work on windows (I find no trace of fcntl in the windows docs). Even if we find a way to guess the open mode on windows somehow, I am not convinced that is the right way forward here. I would rather we find a way to fix the api so that it is harder to use incorrectly, then trying to guess what should happen when the api is used in a potentially incorrect way.
>
> What is original reason you needed this patch for? Could we just return a null FILE* if the user didn't call SetOptions?


While I was writing tests for my python files branch, I first tested the simple case of creating a SBFile with a descriptor, and found to my surprise that almost nothing in LLDB could actually write to that file, because everything expected a FILE* stream and it couldn't make one.

Should I just add an options argument to SetDescriptor instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67792/new/

https://reviews.llvm.org/D67792