[Lldb-commits] [PATCH] D67792: bugfix: llvm_private::File::GetStream() can fail if m_options == 0

Fri Sep 20 05:37:18 PDT 2019

labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.

It doesn't look like this will work on windows (I find no trace of fcntl in the windows docs). Even if we find a way to guess the open mode on windows somehow, I am not convinced that is the right way forward here. I would rather we find a way to fix the api so that it is harder to use incorrectly, then trying to guess what should happen when the api is used in a potentially incorrect way.

What is original reason you needed this patch for? Could we just return a null FILE* if the user didn't call SetOptions?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67792/new/

https://reviews.llvm.org/D67792