[Lldb-commits] [PATCH] D66654: 2/2: Process formatters in reverse-chronological order

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil updated this revision to Diff 219147.
jankratochvil added a comment.

I have tried the `MapVector` with `RegularExpressionSP` as its key as suggested by @labath but that would be even more code than the `std::list` I provided here, both for its custom shared-pointer sorting and for its `EmptyKey`+`TombstoneKey` if we should not put `std::map` there.
So I returned back to a single `std::vector` as originally suggested by @labath and after fixing missing `Delete` in the `Add` implementation for vector it I think that may be a good compromise from all the variants.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66654/new/

https://reviews.llvm.org/D66654

Files:
  lldb/include/lldb/DataFormatters/FormattersContainer.h
  lldb/include/lldb/Utility/RegularExpression.h
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-advanced/TestDataFormatterAdv.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66654.219147.patch
Type: text/x-patch
Size: 5523 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190906/8c1e8ed2/attachment.bin>