[Lldb-commits] [PATCH] D66654: 2/2: Process formatters in reverse-chronological order

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 2 06:51:00 PDT 2019


jankratochvil added a comment.

In D66654#1654713 <https://reviews.llvm.org/D66654#1654713>, @labath wrote:

> The most common operations are lookup (which are linear in any case),


There are also lookups by name <https://lldb.llvm.org/use/variable.html#finding-formatters-101> (`GetExact`) which are logarithmic now by that `std::map`.

I can try the `MapVector`. I just tried not to regress performance by using optimal data structures. If one was concerned about performance there can be done many other easy improvements of the existing code.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66654/new/

https://reviews.llvm.org/D66654





More information about the lldb-commits mailing list