[Lldb-commits] [lldb] r370706 - [lldb][NFC] Unify log files in commands/log/basic

[Raphael Isemann via lldb-commits]

Author: teemperor
Date: Tue Sep  3 01:30:17 2019
New Revision: 370706

URL: http://llvm.org/viewvc/llvm-project?rev=370706&view=rev
Log:
[lldb][NFC] Unify log files in commands/log/basic

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py?rev=370706&r1=370705&r2=370706&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/commands/log/basic/TestLogging.py Tue Sep  3 01:30:17 2019
@@ -21,21 +21,19 @@ class LogTestCase(TestBase):
         super(LogTestCase, self).setUp()
         self.log_file = self.getBuildArtifact("log-file.txt")
 
-    def test(self):
+    def test_file_writing(self):
         self.build()
         exe = self.getBuildArtifact("a.out")
         self.expect("file " + exe,
                     patterns=["Current executable set to .*a.out"])
 
-        log_file = os.path.join(self.getBuildDir(), "lldb-commands-log.txt")
-
-        if (os.path.exists(log_file)):
-            os.remove(log_file)
+        if (os.path.exists(self.log_file)):
+            os.remove(self.log_file)
 
         # By default, Debugger::EnableLog() will set log options to
         # PREPEND_THREAD_NAME + OPTION_THREADSAFE. We don't want the
         # threadnames here, so we enable just threadsafe (-t).
-        self.runCmd("log enable -t -f '%s' lldb commands" % (log_file))
+        self.runCmd("log enable -t -f '%s' lldb commands" % (self.log_file))
 
         self.runCmd("command alias bp breakpoint")
 
@@ -45,12 +43,12 @@ class LogTestCase(TestBase):
 
         self.runCmd("log disable lldb")
 
-        self.assertTrue(os.path.isfile(log_file))
+        self.assertTrue(os.path.isfile(self.log_file))
 
-        f = open(log_file)
+        f = open(self.log_file)
         log_lines = f.readlines()
         f.close()
-        os.remove(log_file)
+        os.remove(self.log_file)
 
         self.assertGreater(
             len(log_lines),