[Lldb-commits] [lldb] r370702 - [lldb][NFC] Remove setup boilerplate from types/ tests

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 3 00:33:32 PDT 2019


Author: teemperor
Date: Tue Sep  3 00:33:32 2019
New Revision: 370702

URL: http://llvm.org/viewvc/llvm-project?rev=370702&view=rev
Log:
[lldb][NFC] Remove setup boilerplate from types/ tests

This code doesn't seem to be necessary anymore.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypes.py
    lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypesExpr.py
    lldb/trunk/packages/Python/lldbsuite/test/types/TestFloatTypes.py
    lldb/trunk/packages/Python/lldbsuite/test/types/TestFloatTypesExpr.py
    lldb/trunk/packages/Python/lldbsuite/test/types/TestIntegerTypes.py
    lldb/trunk/packages/Python/lldbsuite/test/types/TestIntegerTypesExpr.py
    lldb/trunk/packages/Python/lldbsuite/test/types/TestRecursiveTypes.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypes.py?rev=370702&r1=370701&r2=370702&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypes.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypes.py Tue Sep  3 00:33:32 2019
@@ -17,14 +17,6 @@ class DoubleTypesTestCase(AbstractBase.G
 
     mydir = AbstractBase.GenericTester.compute_mydir(__file__)
 
-    def setUp(self):
-        # Call super's setUp().
-        AbstractBase.GenericTester.setUp(self)
-        # disable "There is a running process, kill it and restart?" prompt
-        self.runCmd("settings set auto-confirm true")
-        self.addTearDownHook(
-            lambda: self.runCmd("settings clear auto-confirm"))
-
     def test_double_type(self):
         """Test that double-type variables are displayed correctly."""
         self.build_and_run('double.cpp', set(['double']))

Modified: lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypesExpr.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypesExpr.py?rev=370702&r1=370701&r2=370702&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypesExpr.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/types/TestDoubleTypesExpr.py Tue Sep  3 00:33:32 2019
@@ -21,14 +21,6 @@ class DoubleTypesExprTestCase(AbstractBa
     # test/types failures for Test*TypesExpr.py: element offset computed wrong
     # and sign error?
 
-    def setUp(self):
-        # Call super's setUp().
-        AbstractBase.GenericTester.setUp(self)
-        # disable "There is a running process, kill it and restart?" prompt
-        self.runCmd("settings set auto-confirm true")
-        self.addTearDownHook(
-            lambda: self.runCmd("settings clear auto-confirm"))
-
     def test_double_type(self):
         """Test that double-type variable expressions are evaluated correctly."""
         self.build_and_run_expr('double.cpp', set(['double']))

Modified: lldb/trunk/packages/Python/lldbsuite/test/types/TestFloatTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/types/TestFloatTypes.py?rev=370702&r1=370701&r2=370702&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/types/TestFloatTypes.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/types/TestFloatTypes.py Tue Sep  3 00:33:32 2019
@@ -17,14 +17,6 @@ class FloatTypesTestCase(AbstractBase.Ge
 
     mydir = AbstractBase.GenericTester.compute_mydir(__file__)
 
-    def setUp(self):
-        # Call super's setUp().
-        AbstractBase.GenericTester.setUp(self)
-        # disable "There is a running process, kill it and restart?" prompt
-        self.runCmd("settings set auto-confirm true")
-        self.addTearDownHook(
-            lambda: self.runCmd("settings clear auto-confirm"))
-
     def test_float_type(self):
         """Test that float-type variables are displayed correctly."""
         self.build_and_run('float.cpp', set(['float']))

Modified: lldb/trunk/packages/Python/lldbsuite/test/types/TestFloatTypesExpr.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/types/TestFloatTypesExpr.py?rev=370702&r1=370701&r2=370702&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/types/TestFloatTypesExpr.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/types/TestFloatTypesExpr.py Tue Sep  3 00:33:32 2019
@@ -21,14 +21,6 @@ class FloatTypesExprTestCase(AbstractBas
     # test/types failures for Test*TypesExpr.py: element offset computed wrong
     # and sign error?
 
-    def setUp(self):
-        # Call super's setUp().
-        AbstractBase.GenericTester.setUp(self)
-        # disable "There is a running process, kill it and restart?" prompt
-        self.runCmd("settings set auto-confirm true")
-        self.addTearDownHook(
-            lambda: self.runCmd("settings clear auto-confirm"))
-
     def test_float_type(self):
         """Test that float-type variable expressions are evaluated correctly."""
         self.build_and_run_expr('float.cpp', set(['float']))

Modified: lldb/trunk/packages/Python/lldbsuite/test/types/TestIntegerTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/types/TestIntegerTypes.py?rev=370702&r1=370701&r2=370702&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/types/TestIntegerTypes.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/types/TestIntegerTypes.py Tue Sep  3 00:33:32 2019
@@ -10,14 +10,6 @@ class IntegerTypesTestCase(AbstractBase.
 
     mydir = AbstractBase.GenericTester.compute_mydir(__file__)
 
-    def setUp(self):
-        # Call super's setUp().
-        AbstractBase.GenericTester.setUp(self)
-        # disable "There is a running process, kill it and restart?" prompt
-        self.runCmd("settings set auto-confirm true")
-        self.addTearDownHook(
-            lambda: self.runCmd("settings clear auto-confirm"))
-
     def test_char_type(self):
         """Test that char-type variables are displayed correctly."""
         self.build_and_run('char.cpp', set(['char']), qd=True)

Modified: lldb/trunk/packages/Python/lldbsuite/test/types/TestIntegerTypesExpr.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/types/TestIntegerTypesExpr.py?rev=370702&r1=370701&r2=370702&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/types/TestIntegerTypesExpr.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/types/TestIntegerTypesExpr.py Tue Sep  3 00:33:32 2019
@@ -10,14 +10,6 @@ class IntegerTypesExprTestCase(AbstractB
 
     mydir = AbstractBase.GenericTester.compute_mydir(__file__)
 
-    def setUp(self):
-        # Call super's setUp().
-        AbstractBase.GenericTester.setUp(self)
-        # disable "There is a running process, kill it and restart?" prompt
-        self.runCmd("settings set auto-confirm true")
-        self.addTearDownHook(
-            lambda: self.runCmd("settings clear auto-confirm"))
-
     def test_char_type(self):
         """Test that char-type variable expressions are evaluated correctly."""
         self.build_and_run_expr('char.cpp', set(['char']), qd=True)

Modified: lldb/trunk/packages/Python/lldbsuite/test/types/TestRecursiveTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/types/TestRecursiveTypes.py?rev=370702&r1=370701&r2=370702&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/types/TestRecursiveTypes.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/types/TestRecursiveTypes.py Tue Sep  3 00:33:32 2019
@@ -17,10 +17,7 @@ class RecursiveTypesTestCase(TestBase):
     def setUp(self):
         # Call super's setUp().
         TestBase.setUp(self)
-        # disable "There is a running process, kill it and restart?" prompt
-        self.runCmd("settings set auto-confirm true")
-        self.addTearDownHook(
-            lambda: self.runCmd("settings clear auto-confirm"))
+
         # Find the line number to break for main.c.
         self.line = line_number('recursive_type_main.cpp',
                                 '// Test at this line.')




More information about the lldb-commits mailing list